cis-oss/notify
2
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects 1 Releases 1 Wiki Activity

Feature/release prep #3

Merged
B00tLoad merged 4 commits from feature/release-prep into develop 2025-08-31 15:50:22 +02:00
Conversation 3 Commits 4 Files Changed 2 +5 -2
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 98cd99e27a - Show all commits

7
package.json
View File

@@ -3,8 +3,7 @@
"description": "A client for Pushover, a service for sending notifications. Written in TypeScript. Supports sending to multiple users.",
"homepage": "https://cis-oss.github.io/pushover",
"version": "0.0.1",
"types": "dist/index.d.ts",
"main": "dist/index.js",
"main": "src/index.ts",
"author": {
"email": "hi@b00tload.space",
copilot-pull-request-reviewer[bot] commented 2025-08-31 15:08:16 +02:00 (Migrated from github.com)
Review
Copy Link

Setting main to a TypeScript file may cause issues for consumers who don't have TypeScript configured. Consider keeping main pointing to the compiled JavaScript and using a separate field like 'source' for the TypeScript entry point during development.

  "main": "dist/index.js",
  "source": "src/index.ts",
Setting main to a TypeScript file may cause issues for consumers who don't have TypeScript configured. Consider keeping main pointing to the compiled JavaScript and using a separate field like 'source' for the TypeScript entry point during development. ```suggestion "main": "dist/index.js", "source": "src/index.ts", ```
B00tLoad commented 2025-08-31 15:15:50 +02:00 (Migrated from github.com)
Review
Copy Link

Not applicable, as this is solved later in the file, in the publish config.

Not applicable, as this is solved later in the file, in the publish config.
"name": "Alix von Schirp",
@@ -79,5 +78,9 @@
"*.{js,ts,jsx,tsx,json,css,md}": "prettier --write"
},
"packageManager": "pnpm@10.6.5",
"publishConfig": {
"main": "dist/index.js",
"types": "dist/index.d.ts"
},
"type": "module"
}